Skip to content

fix: add no-arg RevokeToken() and expose GetAccessToken()#19

Merged
IgorHorta merged 1 commit intomainfrom
fix/revoke-token-self
Mar 2, 2026
Merged

fix: add no-arg RevokeToken() and expose GetAccessToken()#19
IgorHorta merged 1 commit intomainfrom
fix/revoke-token-self

Conversation

@IgorHorta
Copy link
Contributor

@IgorHorta IgorHorta commented Feb 27, 2026 •
edited
Loading

Description 📣

Fixes a usability gap where callers had no way to revoke their own session after authenticating.

All auth methods (LdapAuthLogin, UniversalAuthLogin, AwsAuthLogin, etc.) store the access token internally but never exposed it, making it impossible to call RevokeToken(token) — the caller simply had no way to obtain the token value.

Changes

  • AuthClient.RevokeToken() — no-arg overload that revokes the currently authenticated session using the internally stored token
  • AuthClient now tracks the current access token privately, passed through to new instances created on re-authentication

Usage

Before this fix, callers had no way to revoke their session:

// No way to get the token to pass here
sdk.Auth().LdapAuthLogin(input);
sdk.Auth().RevokeToken(???);

Now it works without any token handling:

sdk.Auth().LdapAuthLogin(input);
// ... business logic ...
sdk.Auth().RevokeToken(); // revokes current session

The explicit RevokeToken(String accessToken) overload still exists for cases where you want to revoke a specific token.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

@greptile-apps
Copy link

greptile-apps bot commented Feb 27, 2026 •
edited
Loading

Greptile Summary

Adds convenient no-arg RevokeToken() method that revokes the currently authenticated session without requiring callers to track the access token.

Key Changes:

  • AuthClient now tracks currentAccessToken internally across all auth methods (UniversalAuthLogin, LdapAuthLogin, AwsAuthLogin, SetAccessToken)
  • New RevokeToken() no-arg overload enables self-revocation using the stored token
  • Token properly carried through re-authentication by passing it to new AuthClient instances
  • Comprehensive tests cover both unit and integration scenarios

Documentation:
How will customers discover this new feature? The repository README points to external documentation at https://infisical.com/docs/sdks/languages/java. Will this new RevokeToken() method be documented there?

Confidence Score: 5/5

  • Safe to merge with high confidence - clean additive change with comprehensive tests
  • This is a well-implemented, non-breaking additive change that solves a real usability gap. All auth methods properly store the token, validation handles null cases, tests cover both success and error scenarios, and the implementation follows existing code patterns.
  • No files require special attention

Important Files Changed

Filename Overview
src/main/java/com/infisical/sdk/resources/AuthClient.java Adds currentAccessToken field and no-arg RevokeToken() method, stores token on all auth operations
src/main/java/com/infisical/sdk/InfisicalSdk.java Passes access token to new AuthClient instances during re-authentication

Last reviewed commit: 61051cf

@IgorHorta
feat: add no-arg RevokeToken() for self-revocation
61051cf 
Adds a no-arg RevokeToken() overload to AuthClient that revokes the
currently authenticated session without requiring the caller to
manually handle the access token.

Previously, all auth login methods (LdapAuthLogin, UniversalAuthLogin,
AwsAuthLogin, etc.) stored the token internally with no public way to
retrieve it, making it impossible to call RevokeToken(token) after
authentication without resorting to workarounds.

The token is now tracked privately inside AuthClient and passed through
to new instances created on re-authentication, so RevokeToken() works
correctly across the full SDK lifecycle.
@IgorHorta IgorHorta force-pushed the fix/revoke-token-self branch from 7264901 to 61051cf Compare February 27, 2026 13:56
@IgorHorta
Copy link
Contributor Author

IgorHorta commented Feb 27, 2026

@greptile review this again plz

@IgorHorta IgorHorta mentioned this pull request Feb 27, 2026
Merged
victorvhs017
victorvhs017 approved these changes Mar 2, 2026
View reviewed changes
Copy link

@victorvhs017 victorvhs017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Java 8 and Java 24, all working good!

@IgorHorta IgorHorta merged commit 547cdac into main Mar 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victorvhs017 victorvhs017 victorvhs017 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IgorHorta @victorvhs017